Widgets editor: Preload request to /sidebars #25726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve performance of initial page load by prefetching the REST API request to /sidebars. - Make it so that the widgetIdToClientId mapping is available by the time core/legacy-widget blocks do their initial render. This means that a pre-rendered form is available to the block which it can use instead of performing an additional XHR request.
noisysocks
added
[Type] Performance
noisysocks
requested review from
spacedmonkey,
TimothyBJacobs and
youknowriad
as code owners
|
While working on this I noticed that something is making a request to
|
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
|
@noisysocks the data layer attempts to resolve the "stub post" before it's available. #25736 should fix it. |
adamziel
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24869.
Improves performance of initial page load by prefetching the REST API request to
/sidebars.Makes it so that the
widgetIdToClientIdmapping is available by the timecore/legacy-widgetblocks do their initial render. This means thatprerenderedEditFormis available to the block which it can use instead of performing an additional XHR request. See [edit-widgets beta] Preload widgets #24855.To test