[RNMobile] Add scrollable screens to the bottom-sheet #26204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: +568 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Merged
6 tasks
2 tasks
|
Hello @dratwas! From the code perspective it looks properly, but I was testing the PR on Android and discovered one regression in slider spacing:
I've noticed also wrong behavior in android back button functionality, however I'm able to reproduce it on master as well and so prolly it should be handled on the separate PR - android hardware back button should move user back to the previous sheet instead of to the main |
mkevins
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
This looks good! I tested the flows in the description via Pixel 3a, and everything is working as expected. Nice work!
I left a minor suggestion for a variable rename, but it is not a blocker.
Edit
Oh, just saw Luke's comment (I guess my browser tab was not refreshed). Let's see about resolving the spacing regression before merging.
packages/block-editor/src/components/block-settings/container.native.js
Outdated
Show resolved
Hide resolved
|
Hey, @lukewalczak I fixed the spacing in the slider component. Could you please check it one more time? :) |
lukewalczak
reviewed
Nov 3, 2020
lukewalczak
reviewed
Nov 3, 2020
packages/components/src/mobile/bottom-sheet/bottom-sheet-navigation/navigation-screen.native.js
Outdated
Show resolved
Hide resolved
lukewalczak
reviewed
Nov 3, 2020
lukewalczak
approved these changes
Nov 3, 2020
6 tasks
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GB-mobile PR: wordpress-mobile/gutenberg-mobile#2741
Motivation:
Since we have navigation inside the bottom-sheet, there is a possibility to have a flat list on some of the screens. In that scenario, we need to remove the scroll view from the bottom-sheet dynamically while switching the screen which generates some issues.
In this PR I moved the ScrollView to the navigation-screen and we can set
isScrollableprop for each screen. I left the ScrollView only for bottom-sheets w/o navigation inside.I added the
isScrollableprop to theBottomSheet.NavigationScreenwhich determines if the content of the screen has FlatList/List/ScrollView inside.How has this been tested?
This PR shouldn't bring any changes in the way the editor works - it is only a different implementation.
Checklist: