Fix 'Multi entity saving -> site editor' e2e failures. #26371
Conversation
Addison-Stavlo
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
Addison-Stavlo
requested review from
noahtallen,
youknowriad,
mattwiebe,
vindl,
Copons,
david-szabo97 and
jeyip
|
I came to the exact same conclusions as you have @Addison-Stavlo while investigating failures in one of @david-szabo97 's recent tickets. What a strange issue 😕 I was reluctant to open a PR to fix the problem by replacing the block we insert, but now that I think more about it, I agree that this is necessary, especially to unblock e2e tests. I'm still concerned about the template part insertion failure. I think it would be worthwhile to create a separate issue (happy to handle that), but I'm curious what your thoughts are. |
Addison-Stavlo
deleted the
fix/multi-entity-save-flow-site-editor-e2e-failures
branch
Yeah, im a bit confused by it as well. The template-part tests that go through inserting seem to be working still. 🤔 Luckily for this test specifically there is no reason to use a template part. |
|
It's possible that we used a second template part block to test nested template part block insertion & dirty states, but I kinda forget :) |
|
Something that might have made the results in this PR confusing is that I'd already made some changes to the test in #26341 which was merged before this. It seems to have been passing ok since #26341 in commits to I definitely observed the same thing, that Template Parts couldn't be inserted. I changed the test to first close the navigation panel (seems unusual, but it wouldn't work without this), and also click a block in the editor before inserting. My feeling was that the inserter was possibly attempting to insert the Template Part somewhere it couldn't be, but when trying out things manually it always worked. Still, I don't really understand the FSE flow that much yet having not worked on it, so happy for the tests to be changed to something more logical. |
Oh interesting! I noticed they weren't failing on github, but running locally after that change I was still seeing them fail at the block insertion step. 🤷♀️ It seems difficult to get local e2e to give the same results as the CI checks sometimes... 🤔 |
* Fix drop zone indicators for non blocks (#25986) * Remove isDraggingBlocks check * Clean up drag and drop data if the user presses escape when dragging * Add comment to ensure avoidance of dragend * Switch to using dragend * Fix archives block render function (#26309) * Code block: preserve indentation on paste (#26347) * Turn off autocomplete for token input. (#26427) * Fix parent post selector: ensure initial value available, search performed, all results shown. (#26397) Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> * [RNMobile] Fix CI issues during `npm ci` (#26455) * Run mobile tests on master * Debug CI * Revert "Debug CI" This reverts commit dec1ebe. * Update react-native-screens ref, pin @react-navigation/native version * Pin @react-navigation/core,router versions * Fix composer test failures due to invalid lock (#26472) * Fix gallery block undo issue (#26377) * Mark change in attributes when gallery mounts as not persistant * Fix typo * Fix package lock changes * Fix some Twenty Twenty One related e2e test failures (#26341) * Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line * insert paragraph instead of tempalte part (#26371) * Fix autosave e2e tests (#26416) * Update how block to render is tracked (#26356) Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com> Co-authored-by: Addison Stavlo <Stavz01@gmail.com> Co-authored-by: O André <nosolosw@users.noreply.github.com>
Description
Should fix the e2e failures in multi-entity-saving tests. Oddly
insertBlock( 'Template Part' )doesn't seem to work consistently anymore (not sure why, manual flow seems to work fine still). Since we just needed to add something/anything to dirty the editor, changing this to a paragraph block seems to fix the test.How has this been tested?
Ensure CI e2e checks don't fail on multi-entity-saving tests.
Run
npm run test-e2e:watchlocally and run themulti-entity-savingfile. Verify tests pass.Screenshots
Types of changes
Checklist: