Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: Fix Meta Boxes Test #26440

Closed
wants to merge 1 commit into from
Closed

E2E Tests: Fix Meta Boxes Test #26440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/editor/plugins/meta-boxes.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe( 'Meta boxes', () => {
await page.waitForNavigation();

// Check the the dynamic block appears.
await page.waitForSelector( '.wp-block-latest-posts' );
await page.waitForSelector( '.wp-block-latest-posts__list' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the absence of the .wp-block-latest-posts class is an actual bug that the failing test has caught rather than a problem with the test itself, but I could be wrong. I don't really know the background of the change that caused it.

Copy link
Contributor Author

@jeyip jeyip Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the description of the PR with my reasoning (sorry I jumped the gun a bit and have been adding details after the fact!).

I feel like the absence of the .wp-block-latest-posts class is an actual bug that the failing test has caught rather than a problem with the test itself

That's what I thought at first as well, but I could only reproduce the problem in the e2e testing environment, and not the dev environment. I have a hunch it might be a false positive, and thought it might be worthwhile to have a temporary fix in the meantime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on it, definitely better to be proactive 😄

I've made an issue for the bug #26441

Copy link
Contributor Author

@jeyip jeyip Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick replies Daniel. Let me know if we think it's better to close this PR for now 🙂

} );

it( 'Should render the excerpt in meta based on post content if no explicit excerpt exists', async () => {
Expand Down