Block Support: Separate opt in for font style and weight options #26844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
requested review from
ajitbohra,
ellatrix,
Soean,
spacedmonkey,
talldan and
TimothyBJacobs
as code owners
hc0503
approved these changes
Nov 10, 2020
|
Tested and confirmed this is working as expected in the instructions. 👍 |
jorgefilipecosta
approved these changes
Nov 10, 2020
packages/block-editor/src/components/font-appearance-control/index.js
Outdated
Show resolved
Hide resolved
| ( { slug } ) => slug === newStyles.fontWeight | ||
| ); | ||
| const newFontWeight = presetWeight | ||
| ? `var:preset|font-weight|${ presetWeight.slug }` |
There was a problem hiding this comment.
Not directly related to this PR but I left a comment regarding the current preset usage on fontStyle and fontWeight PR's.
These things are breaking change and may affect block markup so I guess it is something we should look at and decide as soon as possible
#26444 (review).
There was a problem hiding this comment.
This has been updated to have a separate value property in the presets.
apeatling
approved these changes
Nov 18, 2020
Updates the recently added font appearance block support to separate the style and weight aspects in terms of opting in via block.json. This required: * Updating the detection of support opt in within typography tools * Updating the UI control to handle the situation when only one option is opted into This change also includes adding translation for the combined UI option labels and extracting concerns of how the selections are stored within style attributes from the UI control.
aaronrobertshaw
force-pushed
the
update/font-style-weight-support
branch
from
384528a to
6a4248e
Compare
|
This has now been rebased and updated to be compatible with recent introduction of |
aristath
added a commit
to aristath/q
that referenced
this pull request
Nov 23, 2020
apeatling
approved these changes
Nov 24, 2020
aaronrobertshaw
requested review from
chrisvanpatten and
mkaz
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the recently added font appearance block support to separate the style and weight aspects in terms of opting in via block.json.
This includes:
How has this been tested?
Manually.
Testing Instructions
packages/block-library/src/navigation/block.jsontoggling__experimentalFontStyleoff in the supports arrayblock.jsonagain toggling on__experimentalFontStyleand toggling off__experimentalFontWeightScreenshots
Types of changes
Breaking change.
This changes the block support flags for the font style/weight feature that was recently merged but not yet part of a release.
Checklist: