-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'search' message to add context #2692
Improve 'search' message to add context #2692
Conversation
I still wonder how discoverable the word blocks is for people that don't know about blocks. In saying that 'Search blocks' is better than we currently have. I would be keen on more human language such as 'Find a block' or 'Search for a block' over 'Search blocks'. Could you iterate on that maybe? |
I went for 'Find a block'. It's shorter than 'Search for a block' and feels better to me than 'Search blocks'. |
Codecov Report
@@ Coverage Diff @@
## master #2692 +/- ##
==========================================
+ Coverage 33.16% 33.82% +0.66%
==========================================
Files 182 189 +7
Lines 5530 5661 +131
Branches 963 988 +25
==========================================
+ Hits 1834 1915 +81
- Misses 3130 3171 +41
- Partials 566 575 +9
Continue to review full report at Codecov.
|
I think keeping it as Search is better for translation, find doesn't have the same context. |
This PR is referencing issue #2338
I have updated the Inserter search message to read "Search blocks" to be identical to the screen reader text message above it.