Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes position of upload svg on mobile #2693

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Fixes position of upload svg on mobile #2693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbe1857
Fixes position of svg on mobile
karmatosed Sep 7, 2017
b2d861b
Fix image upload button on mobile view
gziolo Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions editor/header/tools/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@
margin-bottom: 0;
}

@media ( max-width: $break-large ) {
Copy link
Member

@mtias mtias Sep 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use @include break-large() on the upload button component?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to make it mobile first and moved styling to the component's style file.

.wp-core-ui .button.wp-block-image__upload-button.button.button-large {
padding: 6px 21px 6px 6px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed spaces / tabs here.

width: 15px;
}
}

.editor-tools__publish-button.is-saving,
.editor-tools__publish-button.is-saving:disabled {
position: relative;
Expand Down