-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align single half width column to left #27142
Conversation
Size Change: +1.35 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Nice fix @draganescu.
Just to be thorough, I checked the breakpoints later on in the file:
gutenberg/packages/block-library/src/columns/editor.scss
Lines 8 to 20 in 5a90a57
@include break-small() { | |
.editor-styles-wrapper | |
.block-editor-block-list__block.wp-block-column:nth-child(even) { | |
margin-left: $grid-unit-20 * 2; | |
} | |
} | |
@include break-medium() { | |
.editor-styles-wrapper | |
.block-editor-block-list__block.wp-block-column:not(:first-child) { | |
margin-left: $grid-unit-20 * 2; | |
} | |
} |
And they have more specificity, so aren't affected by this resetting of margin.
* remove the auto margin for individual column blocks * update margin values for blocks in blocks to zero insted of auto
* Provide a minimum of code wrapping for the code block. (#26623) * Block Support: Fix font size style when applying block support (#26762) * Fix Separator editor styles (#27071) * Fix the Post author selector for contributors (#26554) Co-authored-by: Riad Benguella <benguella@gmail.com> * Align single half width column to left (#27142) * remove the auto margin for individual column blocks * update margin values for blocks in blocks to zero insted of auto * Add backward compatibility support for lightBlockWrapper in getSaveElement (#27189) * Code block: paste plain text (#27236) * paste plain text option * Add e2e test * Fix crash when null date passed to TimePicker (#27316) * Fix crash when null date passed. * Update test * Fix GH actions "cancel" step (#27025) * use new syntax for setting env var * Update package-lock * Update package-lock again * Remove the button only option from the UI until it can be wired up to something that works in the front end. (#27379) * Fix combobox csuggestion list closure when clicking scrollbar (#27367) Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: andrei draganescu <me@andreidraganescu.info> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Noah Allen <noahtallen@gmail.com> Co-authored-by: Andy Peatling <apeatling@users.noreply.github.com>
Fixes #26538
Adds more specific margin rules to
.wp-block-columns .wp-block
. Should not break anything else.To test: