-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyMCE per block: Trying the temporary content editable approach for cross-block selection #272
Conversation
a39811c
to
1849118
Compare
1849118
to
c884f27
Compare
c884f27
to
15b0d6f
Compare
This seems to be a PR where we start to reimplement a lot of behaviour that we'd normally have with a single content editable field. I'm not sure if it's a good idea to temporary set a global content editable attribute instead of just having it there permanently, but limiting inter-block behaviour where we want it. What's the benefit of introducing |
@iseulde This was a PR to play with multiselection in the multi-prototype instance (as a POC). It's not intended to be merged.
I don't have strong opinions, I tried both approach and this is was the most promising one I could come up with at that moment.
This was introduced to ease the manipulation of the Selection and ranges. I found it easier to work with instead of the different browser implementations of the Selection API. |
I'm closing this for now |
@youknowriad So what do you see as a way to enable inter block selection? Or is the way forward a shared block? |
@iseulde I think the approach in this PR is possible but I'd use your proposal to limit inter block selection to the whole blocks instead of trying to figure out which part of the blocks were selected. |
For now, it supports:
I noticed this introduced a bug when selecting inside a TinyMCE (the cursor jumps)