-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduces margin on placeholder for media #27252
Conversation
Size Change: -8 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
@@ -8,7 +8,6 @@ | |||
|
|||
// @todo: this deserves a refactor, by being moved to the toolbar. | |||
.block-editor-media-placeholder { | |||
margin-bottom: $grid-unit-15; | |||
padding: $grid-unit-15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out you can remove this padding as well, it's inherited by the placeholder component and no longer needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goodness this is hard to unsee. I wish we got a million more small PRs like this one, it really ties the room together. Before:
After:
I left a small comment, but once adressed, let's get this one in.
I also noticed that the Gallery title and icon disappeared somehow. That's a separate issue and seems like a regression? Worth maybe digging up and/or fixing.
Nice work!
Thanks for review @jasmussen
Oh my, let me get into that too. I've got another one coming up for this block as it's got a few little hitches. As tests have passed I will merge this and move onto that. |
This is a small PR to fix the margin on focus for the placeholder.
Before:
After:
Feedback
I would specifically like to know if there are any issues with this fix as placeholders seem a little tangled when it comes to the media blocks.