Reduces margin on placeholder for media #27252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmatosed
added
Needs Design Feedback
|
Size Change: -8 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
jasmussen
reviewed
Nov 26, 2020
| @@ -8,7 +8,6 @@ | |||
|
|
|||
| // @todo: this deserves a refactor, by being moved to the toolbar. | |||
| .block-editor-media-placeholder { | |||
| margin-bottom: $grid-unit-15; | |||
| padding: $grid-unit-15; | |||
There was a problem hiding this comment.
Turns out you can remove this padding as well, it's inherited by the placeholder component and no longer needed!
jasmussen
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
My goodness this is hard to unsee. I wish we got a million more small PRs like this one, it really ties the room together. Before:
After:
I left a small comment, but once adressed, let's get this one in.
I also noticed that the Gallery title and icon disappeared somehow. That's a separate issue and seems like a regression? Worth maybe digging up and/or fixing.
Nice work!
|
Thanks for review @jasmussen
Oh my, let me get into that too. I've got another one coming up for this block as it's got a few little hitches. As tests have passed I will merge this and move onto that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to fix the margin on focus for the placeholder.
Before:
After:
Feedback
I would specifically like to know if there are any issues with this fix as placeholders seem a little tangled when it comes to the media blocks.