Replaced icons with dashicons #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ui-prototype Tinymce single/mimic ui prototype
…ui-prototype Remove block border on type
…ui-prototype Prevent input for non-text selections
…ui-prototype Use functions instead of commands where appropriate
…tyle. Also make it keyboard friendly (WordPress#136) * update the TinyMCE per Block prototype UI to match the Prototype UI style * Adding heading block * Adding a paragraph block and moving to React - preact has some state updating bugs * Allowing removing/merging components using backspace * Handling navigation using arrow keys * Adding a simple quote block
…hs, quotes, headings) (WordPress#148)
- Includes a new drag and drop mockup - Includes an admin with the sidebar closed - Includes an updated Sketch file that has the admin UI stuff
Update Mockups
…ui-prototype Tinymce single/mimic ui prototype
…ui-prototype Hide inline formatting toolbar along with rest of block UI
…ui-prototype Tinymce single/mimic ui prototype
…/mock-ups Update/tinymce single/mock ups
TinyMCE per block: Adding some documentation about the API to the README
…/mock-ups Fix caption check on deselect
Note: It creates additional paragraphs when dragging non editable blocks. This reverts commit bef6be3.
These mockup updates include general refinements and polish, per Github and Slack discussions. Notably around: - Galleries. Props @j-falk for ideas here. Trash and edit buttons when selecting individual images in a gallery, and button for advanced gallery editing, where you'd also be able to add more images to the gallery, or rearrange, in the case of a slideshow version of the gallery. - Drag and drop. Props @iseulde for the idea of showing a blue line for the dropzone. The gray area is a ghost of where you're dragging from, so the blocks don't size around when you drag. - A new approach to inserting content. It generally happens on a newline, and the plus then shows up to the left, where the up/down arrows would show up for a non-empty block. We'd then have a permanent "insert" button somewhere in the Admin UI to go with this, for when you need to insert content between two letters. See also WordPress#78. - Added empty versions of Quote and Image block. Imagine the use case of _type type type, press enter for newline, type `/ima` to open inserter searched to Image, press enter, arrow down, type type type_. In that case you'd simply inserted an image placeholder block which you could later upload to, or pick an image from the media library.
Update mockups
Filenames with unencoded spaces worked yesterday. Suddenly it doesn't. No idea why. Will use dashes instead of spaces in the future.
Fix weirdly broken markdown
|
If you can adjust the PR to use 20x20px icons instead of 24x24px icons, should be good to go 👍 |
|
Closing this for now, will revisit seperately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.