Site Editor: fix app header on small-medium screens #27310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiebe
added
[Type] Bug
mattwiebe
requested review from
vindl,
jasmussen,
Copons,
david-szabo97,
jeyip,
noahtallen and
Addison-Stavlo
|
Size Change: -5.48 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 27, 2020
| .edit-site-header_end { | ||
| // Flex basis prevents the header_end toolbar | ||
| // from collapsing when shrinking the viewport | ||
| flex-basis: $header-toolbar-min-width; |
There was a problem hiding this comment.
I think this is the only place that variable is used. Which means it can be removed from the _variables.scss stylesheet in base-styles now. See also #26827.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes various issues with app header alignment on small-medium screens, particularly with the navigation sidebar open.
It removes a lot of
flexproperties and just allows flexbox to do its thing. This keeps the document dropdown from being perfectly centred, but it improves reliability as we're not trying to compensate for edge cases.Non-
is-primaryicons are simply hidden on < large screens while the navigation sidebar is open to ensure there's enough room.Fixes #27245 #26754
How has this been tested?
Types of changes
Bug fix
Checklist: