Site Logo: Remove line height #27623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
kjellr
changed the title
|
Size Change: +10 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
Nice 👌 |
kjellr
added a commit
to WordPress/theme-experiments
that referenced
this pull request
Dec 10, 2020
This is handled in Gutenberg via WordPress/gutenberg#27623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Site Logo block is a
divwith somealinks inside of it, it's effected by global line height rules: if the line height is tall, the container div will get larger, if it's short, it'll get smaller. This leads to some extra space around the image, which upsets visual alignment:Since it's never actually meant to contain text, we can zero out the line height there, trimming the space down to the minimum size of the image itself: