Columns Block: Add custom gutter widths #27661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: -15 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
This tested well for me. My only question is with nested column blocks where parent gutter setting flows through to any child columns block that hasn't explicitly specified a gutter. Once a child explicitly sets the gutter size it does override the parent setting. This seems reasonable to me, but just wondering if it is the expected behaviour, or if it will confuse users at all when nesting columns? |
That is the nature of CSS, I don't think our users would have the same perspective though. I can see benefits either way. The UI doesn't really inform the user that the setting would cascade. In this case it might be better to require the gutter sizes to be explicitly set on the nested columns. I've made that change, let me know whether you think it's an improvement. |
|
To me this is now works more how you would expect, ie. changes a |
|
+1 for the setting not automatically applying to nested columns; I also think that feels more natural/how I would expect those settings to work as a user. This tested well for me. |
Until the new sidebar controls and system lands, it is preferred to avoid adding any new UI controls to the sidebar.
apeatling
reviewed
Jan 6, 2021
Sorry about that. I'll update the test instructions with an explicit code example. The linked gist from step 6 also contains example block code with the attribute and inline style set. |
apeatling
approved these changes
Jan 7, 2021
|
A new iteration of the block supports mechanism is under way (#28913). Those efforts aim to provide a means to target which inner elements get the block support style applied to them. With that functionality, the columns block could opt into a new spacing > margins block support feature and apply those styles to the inner columns. The current approach in this PR is relatively clean but does not offer the ability to set the gutter sizes via theme.json. I'll revisit this once the new iteration of block supports lands. |
7 tasks
|
Closing this PR. In some environments kses will strip out CSS custom properties from the saved post content. This means when the block is loaded again in the editor is will be deemed invalid. The new approach to applying block support styles to inner blocks is likely to be the best path forward for this. That is, once margins are added to the current spacing block support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10730
Description
Adds the ability to set custom gutter widths for a columns block via a new attribute and inline style.
No new UI control will be added until the new sidebar controls and component system is available.
How has this been tested?
Manually.
Testing Instructions
(it can help make the gutters more obvious if you add inner group blocks with a background color)
gutterSizeattribute to the columns block along with a matching inline style. e.g.--columns-block-gutter-size: 0px;or simply copy and paste in the block code below:Screenshots
Types of changes
New feature.
Checklist: