add comment-form block styles #27673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Bug
|
I would rather say that it's an issue with the block that it assumes that CSS from another block exists on the page. |
I agree. But at the time it made sense since everything was in the same stylesheet... |
|
Is is a lot of styles to copy and paste? I personally would be in favor of doing that and scoping those styles to this block. |
|
Fair point... Done in a4a41d5 👍 |
|
Size Change: +234 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Dec 11, 2020
gziolo
approved these changes
Dec 11, 2020
|
To clarify my previous comment, I was referring to this file: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/style.scss |
Good catch! Done 👍 |
gziolo
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The post-comment-form block depends on the block button's styles. After #25220 got merged, FSE themes will not load the button block's styles unless a button block exists on the page.
This PR adds the button block's styles to the comment form.
Note: This is a less-than-ideal solution. Ideally we'd be able to have style dependencies and the ability to load multiple stylesheets as outlined in #27671.
Screenshots
Before:
After:
Types of changes
Defined
wp-block-buttonas the stylesheet handle for thepost-comment-formblock.Checklist: