[RNMobile] Using deferredEventEmitter to wait for the Editor to be mounted before issuing replaceBlock signal #27944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issuing the replaceBlock signal for edited Stories
This was referenced Dec 31, 2020
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
…ks just loaded in mobile gutenberg can signal the native app of which new clientIds they've been loaded with
mzorz
commented
Jan 25, 2021
.../src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergBridgeJS2Parent.java
Show resolved
Hide resolved
mzorz
added
Mobile App - i.e. Android or iOS
There was a problem hiding this comment.
@mzorz just an update here. I did a first pass on the code. I am going to do another review soon and run some tests so that I can verify the changes made here in connection with the other PRs.
jd-alexander
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at approaching the edition of Stories on mobile by using the
deferredEventEmitterinstead of passing a live callback, which would otherwise get lost if the GutenbergEditor gets killed when opening the Story composer (for Story block editing) on Android and the system decides to claim memory.This approach seems to work, except for the following problem: the
clientIdof a block will not be the same anymore in between Editor startups, so we can't use theblockIdas a means of identifying which Story block to replace. This is what happens on WPAndroid:Given this, we're using some new bridge signals to let the native side know when a Story block has been loaded (after a Gutenberg fireup) passing its newly assigned clientId, and the native side can compare whether this block needs to be replaced with a new one or not by calculating a hash on its contents as seen in the WPAndroid PR.
In summary, this PR basically adds these changes:
mediaFilesBlockReplaceSyncthat gets triggered every time a Story block is loadedUnrelated changes
requestMediaFilesEditorLoadHow has this been tested?
Use WPAndroid PR wordpress-mobile/WordPress-Android#13699
Gutenberg mobile PR wordpress-mobile/gutenberg-mobile#2949
Jetpack PR Automattic/jetpack#18540
Related stories library PR Automattic/stories-android#632
Screenshots
Types of changes
Checklist: