List View: Reduce whitespace and always show nested blocks #28029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunandrews
added
[Feature] List View
|
Size Change: -21.6 kB (-2%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Do you think we should add a max-height as well?
Whilst list view exists in a popover, it feels both cumbersome and fragile to me when it's this long.
How do you feel about making the hover/selected state full-width regardless of nesting level, kind of like figma?
I find the consistency makes the experience of clicking a block feel more intuitive, and this would eliminate the "dead space" to the left of the block icon which can get quite large with heavy nesting.
Possibly something to fix separately, but when I click in to a template part I only see the blocks in that template part:
|
…ton. This makes the whole row clickable, regardless of indentation.
I tried this, but started to get over my head pretty quickly; The
Done.
I find this a little strange, too. I think its something to change as part of resolving #27395. |
talldan
approved these changes
Jan 12, 2021
packages/block-editor/src/components/block-navigation/descender-lines.js
Outdated
Show resolved
Hide resolved
Comment on lines
+39
to
+46
|
|
||
| <BlockNavigationTree | ||
| blocks={ hasHierarchy ? [ rootBlock ] : rootBlocks } | ||
| selectedBlockClientId={ selectedBlockClientId } | ||
| selectBlock={ selectBlock } | ||
| __experimentalFeatures={ __experimentalFeatures } | ||
| showNestedBlocks | ||
| /> |
There was a problem hiding this comment.
The hasHierarchy ? [ rootBlock ] : rootBlocks bit and the associated code in the withSelect function lower down in this file means that when a child block is selected, ListView zooms in to only show a limited part of the tree.
So that could be changed as well. I wonder if it might be good to make the changes to ListView's logic a separate PR?
There was a problem hiding this comment.
I couldn't quite wrap my brain around this logic — its very strange to me, but its the existing behavior. I'm happy to change it, but it might make more sense in a separate PR, perhaps along with adding a sidebar for this list view.
jameskoster
approved these changes
Jan 12, 2021
aristath
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
This PR does a few small things: