Scripts: Prevent mangle of translation functions #28231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ensure that strings are correctly extracted for translation.
|
Size Change: +150 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Adding the backport label so we don't forget to add this to Core webpack config even if it doesn't seem to be as affected as Gutenberg. |
sirreal
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
That's because core doesn't minify the files as heavily like Gutenberg does. See https://build.trac.wordpress.org/browser/branches/5.6/wp-includes/js/dist/i18n.js?marks=1092#L1092 |
Core includes min and non-min as you mentioned. The minified version in core is similarly mangled to |
sirreal
added
[Package] i18n
|
So I'd say no backporting needed IMO |
sirreal
added
Gutenberg Plugin
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
approved these changes
Jan 15, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jan 15, 2021
Reserve translation functions from mangling. This should ensure that strings are correctly extracted for translation.
youknowriad
pushed a commit
that referenced
this pull request
Jan 15, 2021
Reserve translation functions from mangling. This should ensure that strings are correctly extracted for translation.
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #28221 we discovered that a string in the
i18npackage was not translated and not correctly extracted. It's believed this is related to function name mangling in the build optimization.Translation function names should remain unmangled so that they can be properly extracted and processed for translation by Core tooling.
How has this been tested?
Compare the
isRTLfunction declaration in the i18n build asset from this branch with the current release.Current release:
Build from this branch:
The mangled name
iis not extracted for translation, but the_xname should be 👍Fixes: #28221
Types of changes
Bug fix: Translation function names should not be mangled.
Checklist: