Improve visual clarity of reusable block #28318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +203 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
I changed the label to an new "ungroup" icon:
|
mtias
commented
Jan 20, 2021
mtias
commented
Jan 20, 2021
| const blockLabel = getBlockLabel( blockType, attributes ); | ||
| // If label is defined we prioritize it over possible possible | ||
| // block variation match title. | ||
| const blockDisplayName = |
There was a problem hiding this comment.
I don't recall why we were not using BlockTitle here instead of calculating again cc @youknowriad
There was a problem hiding this comment.
There was a lengthy PR with a long discussion about the label here. I think @talldan was involved in it maybe? Though I don't have a direct answer.
There was a problem hiding this comment.
Looks like BlockTitle didn't show the label when this was initially implemented, but was later updated to do so.
Using BlockTitle here is a nice improvement.
mtias
added
the
[Feature] Synced Patterns
mtias
commented
Jan 20, 2021
youknowriad
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Looks good to me.
The only thing about this implementation is that it's not something we could adapt to template parts for instance. While the "reusable blocks" is a concept the block editor knows about, the "template part" is not, it's not a generic concept IMO.
As we continue to improve on template parts it might become more clear how much they should coincide with reusable blocks and it might be good to tweak things again. |
|
Let's merge this. @mtias, could you please rebase |
Only show the name next to the icon if it's a reusable block.
youknowriad
force-pushed
the
add/show-reusable-block-title-in-toolbar
branch
from
be3f707
to
dd59c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #27890.
Closes #28281.
Displays the actual reusable block name in the following places:
Examples