FSE: Parse the template before <head> gets rendered #28319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Feature] Themes
aristath
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +774 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
aristath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently block assets (both scripts & styles) in FSE themes get loaded in the footer. That happens because
wp_head()runs before we parse the template, and therefore when the<head>gets rendered we are not aware of what the page is or contains.This can lead to FOUC and down the line it could get real messy since blocks have no way to enqueue anything in the
<head>.This PR changes that behavior by getting the template contents prior to printing the
<head>.Types of changes
gutenberg_render_the_templatefunction to a newgutenberg_get_the_template_htmlfunction which returns the HTML instead of rendering itgutenberg_render_the_templatefunction now simply echoes the result of thegutenberg_get_the_template_htmlfunction. I couldn't find it used anywhere, but for backwards-compatibility's sake I did not delete it.template-canvas.phpfile we now get the template contents first, and then we continue with printing the contents of the template like before.Checklist: