Components: Integrate "next" Text component #28475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
youknowriad,
gziolo,
ItsJonQ and
jorgefilipecosta
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
force-pushed
the
add/g2-text-component
branch
2 times, most recently
from
69f8c01 to
8096fcd
Compare
sarayourfriend
force-pushed
the
add/g2-text-component
branch
from
8096fcd to
9eb3b24
Compare
sarayourfriend
changed the title
sarayourfriend
force-pushed
the
add/g2-text-component
branch
2 times, most recently
from
6bef9df to
f96e1ec
Compare
sarayourfriend
commented
Jan 26, 2021
| @@ -31,5 +27,5 @@ export function withNext( | |||
| return contextConnect( WrappedComponent, namespace ); | |||
| } | |||
|
|
|||
| return forwardRef( CurrentComponent ); | |||
| return CurrentComponent; | |||
There was a problem hiding this comment.
We cannot automatically forward the ref of any component (for example, you cannot call forward ref on a styled component like Text).
|
Size Change: +1.89 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
@saramarcondes Thank you for working on this one 🙏 !! I gave it some thought. I think we should just replace the current (web) Fortunately, the (current) I poked around, and these seem to be the only places it's being used so far:
I vote that we use it directly 👍 Let me know what you think! If you decide to make the update, I'd be more than happy to help you refactor where it's used + test things out. |
|
@ItsJonQ Sounds good to me! Do you know how to test the |
13 tasks
sarayourfriend
force-pushed
the
add/g2-text-component
branch
from
f96e1ec to
2c93ba0
Compare
32 tasks
sarayourfriend
force-pushed
the
add/g2-text-component
branch
from
2c93ba0 to
ba34af3
Compare
ItsJonQ
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
🚀 from me! Thank you @saramarcondes .
I paired with Sara this afternoon. In attempting to use only the new <Text /> component, we ran into a potential issue with the Navigation component.
For that, we think it would be better to go with the adapter strategy for now. A good follow up would be to double check that using the new version of Text does not break integration with Navigator.
ItsJonQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrates the G2 text component.
How has this been tested?
Textis only used inedit-sitecurrently and I'm unsure how to test it, but I've added stories for the new component that test the adapter and it appears to work so I think this is safe 🙂Types of changes
New feature (non-breaking change to existing Text component)
Checklist: