-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data: graduate the __experimentalResolveSelect function to a stable status #28544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
adamziel,
draganescu,
kevin940726,
nerrad,
noisysocks,
talldan and
tellthemachines
as code owners
January 28, 2021 08:37
Size Change: +90 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
gziolo
added
the
[Type] New API
New API to be used by plugin developers or package users.
label
Jan 28, 2021
@noisysocks, is it something that deserves a dev note for WP 5.7? |
noisysocks
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Jan 29, 2021
It will need a dev note yes but maybe for 5.8 depending on if it makes the cut-off. |
noisysocks
approved these changes
Feb 4, 2021
Thanks @jsnajdr. Could you please add a note to the |
It should be fine to merge it now with the docs that @noisysocks mentioned. |
jsnajdr
force-pushed
the
graduate/resolve-select
branch
from
February 4, 2021 11:08
cbb59d5
to
f65bfc4
Compare
Changelog entry added, going to merge now 👍 |
15 tasks
youknowriad
removed
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Data
/packages/data
[Type] New API
New API to be used by plugin developers or package users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
registry.resolveSelect()
function and theresolveSelect
control are already widely used and they proved useful. They no longer need to be kept in the experimental status.This PR removes the
__experimental
prefix from all definitions and usages.Also addresses a little performance issue pointed out by @noisysocks in ffef5a7#r565022458: instead of mapping the selectors again and again on every call to
getResolveSelectors()
, we now map them all on store creation/registration.