Components: Remove the feature flag for G2 components #28661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Components
32 tasks
|
Size Change: -151 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Feb 2, 2021
gziolo
added
the
[Status] Blocked
|
This PR is blocked until Component System is officially accepted for inclusion in the WordPress core. |
6 tasks
|
@sarayourfriend, do we still need it or can I close it? |
|
I'm not sure. My gut says we should close this and revisit it at a later date. The current integration plan #30503 says that we'll remove all the |
|
Sure, we can always reopen but it feels like we will get there in a different way 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #28624.
This PR removes the feature flag
process.env.COMPONENT_SYSTEM_PHASEthat was added to avoid leaking G2 components into WordPress 5.7 release. Now that beta 1 should happen this week, we can get rid of this temporary solution and plan to roll out G2 components in Gutenberg at a larger scale. There are still two versions of the font size picker, but we should plan to remove the old implementation separately.This PR also includes some clean-up tasks marked in #28624:
FontSizeControlfrom@wordpress/components/uithat is useful for experimentsHow has this been tested?
I tested in WordPress and Storybook that the font size picker still works.
Checklist: