Components: Add HStack #28707
Merged
Components: Add HStack #28707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
force-pushed
the
add/g2-hstack
branch
from
199621f to
4069f46
Compare
|
Size Change: +768 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
|
Since this updates We still need to resolve the E2E font reset issue. Will try to look into that now |
32 tasks
ItsJonQ
force-pushed
the
add/g2-hstack
branch
from
ab7da23 to
68f5417
Compare
2 tasks
gziolo
reviewed
Feb 5, 2021
| @@ -86,8 +86,14 @@ describe( 'Font Size Picker', () => { | |||
| ); | |||
|
|
|||
| await first( await page.$x( FONT_SIZE_LABEL_SELECTOR ) ).click(); | |||
|
|
|||
There was a problem hiding this comment.
It feels like there is some sort of performance regression happening in the new component 🙁 Do you know why it takes longer than before?
There was a problem hiding this comment.
We don't. We may need to break out the react profiler for this one to check and see if there's something going on. There's no noticable regression in the UX, however, it's just from the perspective of the e2e tests. (This also doesn't have to do with the HStack component, FWIW, it's due to an update in G2 itself with the select dropdown to add Portaling to the dropdown component).
There was a problem hiding this comment.
It's acceptable to add those delays when there is a need to wait for network requests or animations but otherwise it should work in the headless mode without any additional changes. I think that there are three things that could help:
- React profiler can validate if there isn't happening some longer processing than before
- React dev tools can identify unnecessary rerenders
- in e2e tests we disable animations when they are behind reduced motion guard, maybe it is missing
There was a problem hiding this comment.
Sounds good to me. @ItsJonQ and I can put our heads together on this one this week to figure it out.
| @@ -114,6 +120,10 @@ describe( 'Font Size Picker', () => { | |||
| await pressKeyTimes( 'Backspace', 5 ); | |||
| await page.keyboard.press( 'Enter' ); | |||
|
|
|||
| // Disable reason: Wait for changes to apply. | |||
| // eslint-disable-next-line no-restricted-syntax | |||
| await page.waitForTimeout( 1000 ); | |||
There was a problem hiding this comment.
1 second to wait is a lot. It should be further investigated.
There was a problem hiding this comment.
I think this doesn't need to be 1 whole second @ItsJonQ ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add G2's HStack component
How has this been tested?
Storybook story works and unit tests pass
Types of changes
New feature
Checklist: