Move theme.json support check to class #28788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
oandregal
added
[Type] Code Quality
aristath
reviewed
Feb 5, 2021
| * | ||
| * @var boolean | ||
| */ | ||
| private static $theme_has_support = null; |
There was a problem hiding this comment.
Just out of curiosity, is there a difference if we skip the = null part?
Usually I'd just write it like private static $theme_has_support;
There was a problem hiding this comment.
Nah, I don't think it'd matter in this particular case.
I understand it's a good practice to always initialize them and be explicit so you don't have to think about how the engine would do it and avoid weird cases:
- there's an uninitialized variable, you think the engine is going to initialize it to null
- with that expectation, in certain places of the code you use the
issetcheck - however, the engine decides to initialize it to an empty string because of some type checking it has done
- result: weird bug!
I don't know how much of this holds true for modern engines in any language VS being a no longer necessary convention people still do.
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the maturation of
WP_Theme_JSON_Resolver. It ports an existing method that was declared inglobal-styles.phpinto this class, following up on some recent improvements #28786 #28700Changes:
WP_Theme_JSON_Resolver::theme_has_support().