Cover: Add missing align attr to deprecation #28796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Block] Cover
|
Size Change: +213 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
This was referenced Feb 5, 2021
The Cover align attribute may be lost during deprecation handling as can be observed in the deprecation test. The attribute should be parsed and preserved when the block is upgraded.
WunderBart
force-pushed
the
fix/deprecation-missing-align
branch
from
a8db4d1 to
e929bfe
Compare
|
cc/ @nosolosw, we might want to include this in a 9.9 point release 🙂 |
ockham
reviewed
Feb 9, 2021
Comment on lines
33
to
35
| align: { | ||
| type: 'string', | ||
| }, |
There was a problem hiding this comment.
I'm not entirely sure this is the correct fix 🤔
The 4th deprecation actually uses a supports declaration for align:
gutenberg/packages/block-library/src/cover/deprecated.js
Lines 419 to 421 in 8a39954
So maybe we need to copy that to all more recent deprecations? 🤔
cc/ @gziolo since AFAICT you wrote that deprecation.
There was a problem hiding this comment.
Did I? It might be as well moving code 😅
The best way to verify is to copy the old version in the post and check if it properly converts.
There was a problem hiding this comment.
I'm not entirely sure this is the correct fix 🤔
The 4th deprecation actually uses a
supportsdeclaration foralign:gutenberg/packages/block-library/src/cover/deprecated.js
Lines 419 to 421 in 8a39954
So maybe we need to copy that to all more recent deprecations? 🤔
cc/ @gziolo since AFAICT you wrote that deprecation.
Followed this advice in 0183f5e. Had to regenerate the fixtures but it looks better now and works well for me! Thanks! ❤️
oandregal
pushed a commit
that referenced
this pull request
Feb 11, 2021
oandregal
pushed a commit
that referenced
this pull request
Feb 11, 2021
|
Adding a minimal, manual test case:
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
7 tasks
noisysocks
pushed a commit
that referenced
this pull request
Mar 5, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cover align attribute may be lost during deprecation handling as can be observed in the deprecation test. The attribute should be parsed and preserved when the block is upgraded.
Types of changes
Checklist: