-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Add VStack #28798
Components: Add VStack #28798
Conversation
Size Change: -731 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 from me! Thank you @saramarcondes . With that, Flex, HStack, and VStack are in 😍
|
||
function Example() { | ||
return ( | ||
<VStack css={[ui.frame.height(200)]}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed avoiding these css props in public components right? what's the status of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point, we should avoid it in the examples as well. I'll make a note to clean these up as we go along
cc/ @ItsJonQ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarayourfriend Good call. We'll remove it from the examples
Description
Add G2 VStack component.
How has this been tested?
Unit tests pass. Component is unused.
Types of changes
New feature
Checklist: