Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish social links when inside navigation. #28836

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Polish social links when inside navigation. #28836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95256f7
Polish social links when inside navigation.
jasmussen Feb 8, 2021
c43303b
Remove comment.
jasmussen Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/block-library/src/navigation/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
// Default background and font color
.wp-block-navigation:not(.has-background) .wp-block-navigation__container {
.wp-block-navigation__container {
color: $gray-900;
background-color: $white;
min-width: 200px;
.wp-block-navigation__container {
// Vertically align child blocks, like Social Links or Search.
align-items: center;

// Default background and font color
&:not(.has-background) .wp-block-navigation__container {
.wp-block-navigation__container {
color: $gray-900;
background-color: $white;
min-width: 200px;
}
}
}

Expand Down
7 changes: 5 additions & 2 deletions packages/block-library/src/social-links/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
transition: all 0.1s ease-in-out;
@include reduce-motion("transition");

.is-selected & {
.is-selected > & {
opacity: 0.1;
}

Expand All @@ -40,7 +40,6 @@
// Wrap the remaining placeholders in a container so the plus can overlap.
> .wp-block-social-links__social-placeholder-icons {
display: flex;
position: absolute;
}

& + .block-list-appender,
Expand All @@ -67,6 +66,10 @@
}

// Polish the Appender.
.wp-block-social-links .wp-block-social-links__social-placeholder + .block-list-appender {
position: absolute;
}

.wp-block-social-links .block-list-appender {
padding: 0;

Expand Down