-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List all dependencies when checking licenses in NPM 7 #28909
Conversation
NPM 7 by default only prints the first level of dependencies but we need all of them for this script.
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks correct.
Can you include a note in the CHANGELOG of the package updated?
This file: Something like this should be enough: ## Unreleased
+
+ ### Enhancements
+
+ - Make `check-licenses` command compatible with npm v7 ([#28909](https://github.com/WordPress/gutenberg/pull/28909)).
## 13.0.0 (2021-01-21) |
Thanks @gziolo for the reminder! I've just updated the |
I added another commit, it needs a section to recognize this change as a minor version bump 😄 |
Oops sorry, I forgot to add the the section, thanks for the fix 😊 ! |
Thank you for the actual fix 😄 |
Description
NPM 7 by default only prints the first level of dependencies but we need all of them for the
check-licenses
script.Extracted from "Changes in npm v7":
How has this been tested?
npm i -g npm@latest
npm run check-licenses
(this command should show some warnings)Screenshots
N/A
Types of changes
Bug fix
Checklist: