Components: Add Portal #28981
Merged
Components: Add Portal #28981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
32 tasks
|
Size Change: +28 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/hooks-portal
branch
from
e07ab3b to
5e1316c
Compare
|
@sarayourfriend Hmm! I'm not sure why the |
|
@ItsJonQ I have... no idea how that happened... I'll fix it right away, sorry about that. |
sarayourfriend
force-pushed
the
add/hooks-portal
branch
from
51cc20e to
5e1316c
Compare
|
@sarayourfriend No worries :D! I also updated the Portal test |
|
Will add a quick README now |
sarayourfriend
commented
Feb 17, 2021
Comment on lines
+26
to
+31
| expect( | ||
| document.querySelector( 'body .container .element' ) | ||
| ).toBeFalsy(); | ||
|
|
||
| // Instead, it is rendered at the `body` level. | ||
| expect( document.querySelector( 'body .element' ) ).toBeTruthy(); |
sarayourfriend
force-pushed
the
add/hooks-portal
branch
from
e21625c to
7a321f7
Compare
|
@sarayourfriend Could this PR be related to the error I reported here? https://wordpress.slack.com/archives/C02QB2JS7/p1613690151252200 Builds are failing on latest master for me. |
|
Sorry. Never mind. Just required a fresh npm install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Portal component that wraps reakit's Portal with the ThemeProvider so that themes are correctly applied to portalled elements.
This PR also updates G2 to get fixes to the ThemeProvider props as well as the contextConnect function:
ItsJonQ/g2#263
ItsJonQ/g2#264
How has this been tested?
Unit tests pass
Types of changes
New feature
Checklist: