Add z-index to gallery fig caption to make sure it is still selectable over absolute positioned border #28992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsolute positioned border.
glendaviesnz
added
[Type] Bug
paaljoachim
added
Backport to WP 6.7 Beta/RC
|
Testing using gutenberg.run Added a gallery block. Added another gallery block. |
jasmussen
approved these changes
Feb 15, 2021
|
Size Change: +39 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
paaljoachim
removed
Backport to WP 6.7 Beta/RC
|
As always, let's add an e2e test (in a separate PR) to prevent this issue from re-appearing! 🙂 |
Filed issue #29001 to keep track. |
46 tasks
|
Thanks all! I'll merge, and will cherry-pick to |
ockham
pushed a commit
that referenced
this pull request
Feb 15, 2021
…bsolute positioned border. (#28992) #27312 introduced some absolute positioning to the gallery image border to fix some layout issues, but because this had a z-index specified it was sitting over the top of the caption which could no longer be selected. This PR just adds a z-index to caption also so it sits over the border. Co-authored-by: Glen Davies <glen.davies@a8c.com>
Done. |
ockham
pushed a commit
that referenced
this pull request
Feb 15, 2021
…bsolute positioned border. (#28992) #27312 introduced some absolute positioning to the gallery image border to fix some layout issues, but because this had a z-index specified it was sitting over the top of the caption which could no longer be selected. This PR just adds a z-index to caption also so it sits over the border. Co-authored-by: Glen Davies <glen.davies@a8c.com>
|
Also cherry-picked to |
|
Definitely :+1 See #28992 (comment) and #29001 🙂
🤔 |
|
The z-index was added originally due to some specific markup in the editor view, causing the focus style to be partially cropped. I would imagine this focus style benefits from the Image block CSS once the refactor to use inneblocks lands. An E2E test that verifies that the caption is clickable should still be relevant for that refactor, but the z-index might not. |
Exactly. I meant a test for the behaviour, not the implementation. I wasn't clear. :) |
|
Similar case in 3741862-zd (can't edit gallery image captions). |
|
Similar Issue here 27774020-hc. Had them pre-enter the caption before inserting the images on the page itself as a workaround. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 5, 2021
…bsolute positioned border. (#28992) #27312 introduced some absolute positioning to the gallery image border to fix some layout issues, but because this had a z-index specified it was sitting over the top of the caption which could no longer be selected. This PR just adds a z-index to caption also so it sits over the border. Co-authored-by: Glen Davies <glen.davies@a8c.com>
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Mar 5, 2021
…bsolute positioned border. (#28992) #27312 introduced some absolute positioning to the gallery image border to fix some layout issues, but because this had a z-index specified it was sitting over the top of the caption which could no longer be selected. This PR just adds a z-index to caption also so it sits over the border. Co-authored-by: Glen Davies <glen.davies@a8c.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28989
Description
#27312 introduced some absolute positioning to the gallery image border to fix some layout issues, but because this had a z-index specified it was sitting over the top of the caption which could no longer be selected.
This PR just adds a z-index to caption also so it sits over the border.
Testing
Before:
After:
Types of changes
CSS change