Support skipping serialization in the color hook (block supports mechanism) #29142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic blocks that do not want serialization could avoid it by not calling get_block_wrapper_attributes. However, there may be cases in which some attributes should be serialized and others should not.
oandregal
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
oandregal
added
the
Global Styles
|
Size Change: +260 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
One thing I've noticed by trying this out in the social links block is that the current color panel uses "Icon color" and "Icon background color" as names while the block supports mechanism uses "Text color" and "Background color" (and doesn't allow blocks to change it), see:
Given the current direction (allow the serialization from block attributes => DOM to be up to the block), I think we need the ability for blocks to change the names of this as well. Was thinking about how to integrate this into the supports mechanism. We are also going to need to declare "selectors" per property as per #28913 |
|
I'm not sure I like the "meta" indirection. The labels could be just |
|
@youknowriad makes sense. So, this should be ready to land then. I can work on adding the labels and selectors as follow-ups PRs, to keep PRs very small and focused to reduce the reviewer's time required to land them. |
20 tasks
|
I've added the list of tasks at #28913 Will keep it updated as things evolve. |
youknowriad
reviewed
Feb 19, 2021
lib/block-supports/colors.php
Outdated
| @@ -60,6 +60,14 @@ function gutenberg_register_colors_support( $block_type ) { | |||
| */ | |||
| function gutenberg_apply_colors_support( $block_type, $block_attributes ) { | |||
| $color_support = gutenberg_experimental_get( $block_type->supports, array( 'color' ), false ); | |||
|
|
|||
| if ( array_key_exists( 'skipSerialization', $color_support ) && $color_support['skipSerialization'] ) { | |||
| return array( | |||
There was a problem hiding this comment.
We can probably return an empty array here, don't you think?
There was a problem hiding this comment.
Oh, yes, it doesn't make sense as it was. Fixed in 29d4578
youknowriad
reviewed
Feb 19, 2021
youknowriad
approved these changes
Feb 19, 2021
You mean |
|
I will push that change after lunch and will merge. |
oandregal
changed the title
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first step in supporting a more fine-grained block supports mechanism as described at #28913
Follow-up PRs should be created to migrate specific blocks to use this. The testing steps illustrate a use case for this: make the social links use the colors from the block support mechanism, so they are exposed from theme.json.
How has this been tested?
Using the TT1-blocks:
Compile this branch.
Go to the post editor and create a social links block with some icons:
textColorandbackgroundColorattributes and they have the same value as the color you selected.