Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop some dead code from the Visual Editor Component #2937

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Drop some dead code from the Visual Editor Component #2937

merged 1 commit into from
Oct 9, 2017

Conversation

youknowriad
Copy link
Contributor

No description provided.

@youknowriad youknowriad self-assigned this Oct 9, 2017
@youknowriad youknowriad requested a review from ellatrix October 9, 2017 15:36
ellatrix
ellatrix approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Could you link the commit that removed this.onKeyDown? I'm surprised the linter did not error...

@youknowriad
Copy link
Contributor Author

@iseulde I don't know which commit did this :P, Let me try to find it

@youknowriad
Copy link
Contributor Author

Got it, it was removed here #1944

@youknowriad youknowriad merged commit b1eda06 into master Oct 9, 2017
@youknowriad youknowriad deleted the drop/dead-code-visual-editor branch October 9, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

Assignees

@youknowriad youknowriad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @ellatrix