Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title: Unselect title by blur event #2948

Merged
merged 3 commits into from
Oct 20, 2017
Merged

Title: Unselect title by blur event #2948

merged 3 commits into from
Oct 20, 2017

Commits on Oct 20, 2017

  1. Title: Unselect title by blur event 

    Title: Detect blur outside root container node

Components: Enable title wrapper as focusable

Firefox won't include relatedTarget on blur event for div unless focusable. Assign as negative tab index to avoid creating a tab stop.
    @aduth
    aduth committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    8f02dca View commit details
    Browse the repository at this point in the history

  2. Components: Refactor ClipboardButton to not lose focus 

    Components: Refactor ClipboardContainer to access sibling node

Components: Move ClipboardButton callbacks to function

Ensure that if props have changed since original mount, latest value is reflected at time of copy

Components: Render clipboard button with wrapping container

Components: Clear selection on clipboard button press

Clearing selection will move focus back to the triggering button,
ensuring that it is not reset to the body, and further that it is
kept within the rendered node.
    @ephox-mogran @aduth
    ephox-mogran authored and aduth committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    45864c7 View commit details
    Browse the repository at this point in the history

  3. Permalink: Fix typo on unmount lifecycle method 

    Was logging error when unselecting title after clicking copy since timeout was never canceled
    @aduth
    aduth committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    8ef869d View commit details
    Browse the repository at this point in the history