Fix inline block styles minification issues with calc() #29554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.22 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
gziolo
added
[Type] Bug
gziolo
approved these changes
Mar 8, 2021
|
Fair point @gziolo |
A test case with CSS variables might be a good candidate. @jasmussen, you are the expert, any ideas? |
|
I appreciate your kind words, but I have a sense that Ari is stronger in custom properties than I am :) |
|
I added a test for a css-var & calc() combo 😺 |
gziolo
approved these changes
Mar 8, 2021
6 tasks
33 tasks
aristath
added a commit
to aristath/q
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29518
How has this been tested?
calc.width:calc(50%-.625em). After the PR, the spaces insidecalc()are not stripped so the result iswidth:calc(50% - .625em)Types of changes
Used the regex from https://stackoverflow.com/a/44350195 instead of a previous buggy one that didn't take calc into account.
Checklist: