Components: Add Heading #29592
Merged
Components: Add Heading #29592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
32 tasks
|
Size Change: +989 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Mar 5, 2021
|
Taking a look at the failing snapshots now. From what I can see... the |
|
@ItsJonQ Those diffs were unreadable, but it was because of the |
ItsJonQ
reviewed
Mar 5, 2021
There was a problem hiding this comment.
@sarayourfriend Thank you for adding this! I left a couple of comments for copy changes in README/types. That's it 😊
sarayourfriend
removed
the
Needs Accessibility Feedback
diegohaz
reviewed
Mar 11, 2021
There was a problem hiding this comment.
The code looks great! 👌
But I'm seeing this error when I try to run storybook:
packages/components/src/ui/heading/hook.ts:64:29 - error TS2345: Argument of type 'HeadingSize' is not assignable to parameter of type 'number | undefined'.
Type '"1"' is not assignable to type 'number | undefined'.
64 size: getHeadingFontSize( level ),
I guess whether getHeadingFontSize should accept strings or we should cast level to a number.
|
@diegohaz That's interesting, have you run |
Ah, you're right! I forgot to |
diegohaz
reviewed
Mar 11, 2021
sarayourfriend
force-pushed
the
add/hooks-heading
branch
from
0250ebc to
672ebd6
Compare
ItsJonQ
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
🚀 from me! Thanks @sarayourfriend + @diegohaz !
The a11y prop improvement is really neat!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
Headingcomponent. Also upgrades G2 so make sure tonpm installwhen testing.@diegohaz can you review this from an a11y perspective, especially regarding not using the semantichxelements for this?How has this been tested?
Storybook and unit tests
Screenhots
Types of changes
New feature
Checklist: