-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deregister TOC block until issues are resolved #29718
Conversation
Size Change: -1.68 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Thanks! I agree on the first two being blockers, but I think #29562 could come later. |
Good point, thank you. Edited the description 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ari! This is coming in handy for the 10.2.0 RC that I'm about to release 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm already working on a refactor PR, so hopefully we should be able to reintroduce the block in Gutenberg 10.3. 👍
Here's the refactor PR: #29739. |
Description
This PR temporarily deregisters the TOC block.
It should be added back once these 2 tickets are resolved:
This 3rd issue would improve the experience, but not a blocker:
How has this been tested?
Tested by making sure the TOC block is not available to users.
Types of changes
Commented-out the lines that register the block.
Since this is only temporary, commenting-out seems appropriate.
The e2e fixtures were removed to make the tests pass.
cc @mtias
Checklist: