Component System: Button - Add a default type of button #29900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
approved these changes
Mar 16, 2021
|
Size Change: +23 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the
typeofbuttonto the new Button component by default. This is response to the update suggested by @kevin940726 in ItsJonQ/g2#288The reason is because:
<Button>component should havetype="button"by default, or else it will default totype="submit"when placing inside a<form>element.How has this been tested?
Jest tests. I confirmed the
form/submitbehaviour by testing it externally in a CodeSandbox.Checklist: