Block Editor: Standardize loading default block editor settings #30245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
oandregal,
spacedmonkey and
TimothyBJacobs
as code owners
gziolo
added
Backwards Compatibility
gziolo
commented
Mar 25, 2021
gziolo
commented
Mar 25, 2021
gziolo
commented
Mar 25, 2021
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/shim-default-block-editor-settings
branch
from
dc9c498
to
f3903a2
Compare
gziolo
commented
Mar 25, 2021
youknowriad
reviewed
Mar 25, 2021
gziolo
force-pushed
the
update/shim-default-block-editor-settings
branch
from
0b121d5
to
8296b33
Compare
gziolo
force-pushed
the
update/shim-default-block-editor-settings
branch
from
a279f7e
to
66a4d39
Compare
|
I copied over some of the methods developed in WordPress/wordpress-develop#1118 and prefixed them with As mentioned in WordPress/wordpress-develop#1118:
@youknowriad or @nosolosw, what do you think? |
|
Let's move forward with those changes. For now only |
7 tasks
geriux
reviewed
Apr 19, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related WordPress/wordpress-develop#1118.
In preparation for support multiple types of screens that use the block editor, I propose we add a shim for a new function
get_default_block_editor_settingsthat is going to be backported to WordPress core. I'd like to confirm that it works seamlessly with the$postobject that is mostly set tonulloutside of the edit post page. Otherwise, we will need to find a more sophisticated method to ensure we can filter the allowed block types.How has this been tested?
All editors still load:
Types of changes
Checklist: