Widgets: Fix warning when widgets block editor is disabled #30318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a core widget is unregistered then it will not be in $wp_widgets_factory->widgets which causes a PHP warning.
noisysocks
added
[Type] Bug
noisysocks
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 29, 2021
draganescu
deleted the
fix/warning-when-widgets-block-editor-is-disabled
branch
|
I tested this by adding |
ockham
pushed a commit
that referenced
this pull request
Mar 29, 2021
If a core widget is unregistered then it will not be in $wp_widgets_factory->widgets which causes a PHP warning.
|
Cherry-picked to |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30305.
If a core widget is unregistered then it will not be in
$wp_widgets_factory→widgetswhich causes a PHP warning.We also don't need to set
show_instance_in_restonWP_Widget_Blocksince it already declares this.How has this been tested?
add_theme_support( 'widgets-block-editor' );inlib/init.php.Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).