Update design of the resize handles #30339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inverts the white halo as background. - Simplifies the hover bars.
|
Size Change: -25 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 29, 2021
|
Me gusta. I also wonder if the handle could/should be eventually similar to the layout ones, or have a shared visual argot that ultimately connects more with the evolving editor UI.
|
|
Let's land this one. |
priethor
added
the
General Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the visual appearance of the handles to be the inverse of what they are now. Instead of the white halo it uses a white background and leaves the primary color for the outline.
Before:
After:
It also simplifies a bit the hover treatment. I think we need to revisit the hover effect in general but I didn't remove it because it can have an impact on the image block since the bounding box includes the caption.