wp-env: Remove platform-specific destroy commands #30638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Package] Env
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
fullofcaffeine
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27957
When we originally implemented
wp-env destroy, we usedgrepandawkon the command line. These are not compatible with windows, so wp-env would not work on that platform.This re-implements the parts of the destroy command which were not cross-platform. This new approach works because the API for the Docker command is the same on Windows (I've tested it.)
I will note that Docker recommends that folks should run docker commands from inside a WSL2 instance for better performance. (Assuming folks are using the default WSL setup suggested by Docker.) If that's the case, unix commands like grep should be available. But since it's possible to use non-WSL approaches, we definitely still need to support cross-platform syntax.
How has this been tested?
Screenshots
Types of changes
bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).