-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-env: update changelog and CI #30646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
force-pushed
the
try/further-chown-changes
branch
from
April 8, 2021 23:30
33f8356
to
50a885d
Compare
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
noahtallen
force-pushed
the
try/further-chown-changes
branch
from
April 9, 2021 00:38
05b7ed0
to
3ad0f9c
Compare
noahtallen
changed the title
[TEST] Testing changes to tests + wp-env
wp-env: update changelog and CI
Apr 9, 2021
noahtallen
added
[Package] Env
/packages/env
[Type] Enhancement
A suggestion for improvement.
labels
Apr 9, 2021
ockham
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, thanks! CI is green 👍
ribaricplusplus
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after testing #30053 that we could probably update the CI to remove where we used to have to
chmod
the plugin directory to get file uploads working As long as CI passes on this PR, this is good to go.Additionally, I updated the wp-env changelog.