Hide Extended Settings unless Sidebar is opened #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2849, props @DevinWalker for concept. Extended settings is the panel at the bottom that holds extra metaboxes. It is present when a plugin adds such metaboxes, otherwise it's not there. Given that the purpose of being able to dismiss the sidebar is for a simpler, lighter, writing experience, it makes sense to hide this panel if the sidebar panel is hidden. This PR does that.
jasmussen
added
General Interface
youknowriad
approved these changes
Oct 19, 2017
|
Thanks. I agree, it would be good to explore further improvements to the metabox implementation, but this is a great v1, and in the current panel configuration, it'd be good to try with the hiding stuff from this PR. |
|
Yes nice work! Looks good for v1 - I agree. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2849, props @DevinWalker for concept.
Extended settings is the panel at the bottom that holds extra metaboxes. It is present when a plugin adds such metaboxes, otherwise it's not there. Given that the purpose of being able to dismiss the sidebar is for a simpler, lighter, writing experience, it makes sense to hide this panel if the sidebar panel is hidden. This PR does that.
Additionally it fixes a CSS bleed issue for the placeholder text block.
How Has This Been Tested?
Tested in Chrome, WP Docker, with Yoast SEO enabled.
Screenshots (jpeg or gifs if applicable):
Checklist: