wp-env: Disable Xdebug for php < 7.2 #30651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Regression
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
Apr 12, 2021
noahtallen
force-pushed
the
fix/legacy-php-versions
branch
from
b3f1edb
to
72b3ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #27783.
Xdebug 3 does not support PHP versions less than 7.2. Following suggestions in #27783, we will now not attempt to install Xdebug for versions of PHP older than 7.2.
My reasoning for this approach is that wp-env is mostly concerned about the "good defaults", which would mean the latest supported versions of anything, such as WordPress, PHP, Xdebug, etc. It's a bit less concerned with supporting everything completely across every version of every tool, which is why I'm not trying to fallback to an older Xdebug version. I think that would make things more complicated.
How has this been tested?
Locally, with
phpVersioninwp-env.jsonset to 5.6, and then again set to 7.2. In both cases, wp-env start succeeded, and only in the latter case was Xdebug installed. (Verified by looking at the generated Dockerfile)Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).