-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-env: Fix issue with unquoted paths in docker-compose call #30692
Conversation
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd only like to note that docker-compose
npm lib actually has a port
method, so if you want to consistently use it throughout the start.js
file, you can.
Oh nice, thanks for pointing that out! I made a PR to add this command to the docker-compose docs, since we must have not noticed it previously: PDMLab/docker-compose#130. |
3a67919
to
0096d6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Noah!
Description
Resolves #28680. We were calling docker-compose without quoting the path to the config, which meant that paths with spaces crashed the program.
How has this been tested?
Locally on windows. (Theoretically this would also be a problem on other OSes as well)
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).