Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include block title into block switcher label #30808

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Include block title into block switcher label #30808

merged 2 commits into from
Apr 14, 2021

Conversation

Mamaduka
Copy link
Member

Description

Adds block title to block switcher label.

Fixes #30160.

How has this been tested?

  1. Hover or focus on the block/block switcher icon.
  2. Updated label should include block title.

Screenshots

block-switcher-label

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka requested a review from ellatrix as a code owner April 13, 2021 14:53
@Mamaduka Mamaduka added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Apr 13, 2021
@Mamaduka Mamaduka self-assigned this Apr 13, 2021
carolinan
carolinan approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, this will make it easier if the icon is not obvious.

@Mamaduka Mamaduka merged commit e195cbe into WordPress:trunk Apr 14, 2021
@github-actions github-actions bot added this to the Gutenberg 10.5 milestone Apr 14, 2021
@Mamaduka Mamaduka deleted the add/block-title-to-block-switcher branch April 14, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 10.5
Development

Successfully merging this pull request may close these issues.

Enhancement: Include Block Type on hover
2 participants
@Mamaduka @carolinan