Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uploading state to video block #30837

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Add uploading state to video block #30837

merged 1 commit into from
Apr 15, 2021

Conversation

Mamaduka
Copy link
Member

Description

Adds uploading state to the video block, similar to other blocks that let you upload media.

Fixes #30787.

How has this been tested?

  1. Throttle network to 3G via DevTools.
  2. Add a new video block
  3. Upload video.
  4. Uploading state should be visible.

Screenshots

video-block-upload-state

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Apr 14, 2021
@Mamaduka Mamaduka added [Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement. labels Apr 14, 2021
talldan
talldan approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working really well, thanks for picking it up so quickly 🚢

@talldan talldan merged commit 9e6ee0a into WordPress:trunk Apr 15, 2021
@github-actions github-actions bot added this to the Gutenberg 10.5 milestone Apr 15, 2021
@Mamaduka Mamaduka deleted the add/video-block-uploading-state branch April 15, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 10.5
Development

Successfully merging this pull request may close these issues.

Add a clearer uploading state to the video block
2 participants
@Mamaduka @talldan