Replace the document tab with a template tab in template mode #30860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
Size Change: +612 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
|
Looks good:
Though as you can see I was again taken to the block tab 🙈 — not sure what's up. Does this need a code review? Happy to thumb up otherwise. And finally, more of a question for @jameskoster and for a separate future exploration — should the sidebar animate out and then back in as the new "Template" toolbar? |
jameskoster
approved these changes
Apr 15, 2021
Initially I thought yes, but this doesn't feel too bad to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30762
Testing instructions