Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Block: disable media buttons in uploading state #30863

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Image Block: disable media buttons in uploading state #30863

merged 1 commit into from
Apr 15, 2021

Conversation

Mamaduka
Copy link
Member

Description

Updates placeholder's "disable media buttons" logic and adds temporary image state check.

Fixes #30858.

How has this been tested?

  1. Add image block to a post.
  2. Drag and drop image.
  3. Placeholder shouldn't be visible while uploading the image.

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka requested a review from ajlende as a code owner April 15, 2021 09:30
@Mamaduka Mamaduka requested a review from jasmussen April 15, 2021 09:30
@Mamaduka Mamaduka self-assigned this Apr 15, 2021
@Mamaduka Mamaduka added [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Apr 15, 2021
jasmussen
jasmussen approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gloriously simple. Thank you!

now

☝️ the above is how it should work.

@Mamaduka
Copy link
Member Author

Waiting checks to pass and will merge this one.

@Mamaduka Mamaduka merged commit bf9f913 into WordPress:trunk Apr 15, 2021
@Mamaduka Mamaduka deleted the fix/image-block-hide-placeholder branch April 15, 2021 10:46
@github-actions github-actions bot added this to the Gutenberg 10.5 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

@ajlende ajlende Awaiting requested review from ajlende

Assignees

@Mamaduka Mamaduka

Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 10.5
Development

Successfully merging this pull request may close these issues.

Image Block: Drag and drop from desktop shows placeholder when processing
2 participants
@Mamaduka @jasmussen